[DE-544] Adjusting allowRetry implementation #255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #255 +/- ##
==========================================
- Coverage 98.58% 98.54% -0.05%
==========================================
Files 26 26
Lines 3899 3910 +11
==========================================
+ Hits 3844 3853 +9
- Misses 55 57 +2
|
CryptoNinjaGeek
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to #254
Instead of having a separate
retryfunction, it becomes the default behavior of the cursor to always fetch the last batch (that is, only if theallow_retryoption is specified in the AQL query).This adjustment reduces the complexity of the API and makes it easier to use. Also, users may start benefiting directly from this change after upgrading to 3.11, without having to make any refactoring to their existing code. All that is needed now is to set
allow_retry=Trueinarango.aql.AQL.executeI have added a code block to the documentation to illustrate the usage.